pgsql: Back-patch b1ffe3ff into REL_13_STABLE.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Back-patch b1ffe3ff into REL_13_STABLE.
Date: 2025-01-08 21:17:55
Message-ID: E1tVdR5-000YML-8V@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Back-patch b1ffe3ff into REL_13_STABLE.

This is a cherry pick of 4c8e00ae from the 14 branch into the 13 branch.

It avoids an assertion failure when ForwardSyncRequest() tries to
allocate memory while trying to compact the queue, if run in a critical
section. RelationTruncate() gained a critical section in 38c579b0, and
could fail in that way in the 13 branch.

b1ffe3ff originally fixed the same problem with TruncateMultiXact(), but
for that case it only needed to go back as far as 14, where SLRUs
started using the sync request queue. It also fixed a related deadlock
risk that doesn't apply in this case (this case doesn't wait), but it
might exist in theory and it doesn't hurt to keep the code the same as
later branches.

Author: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> (original commit)
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz> (in this new context)
Reported-by: Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>
Discussion: https://postgr.es/m/f98aaa79-80b5-47c9-832a-31416a3a528b%40postgrespro.ru

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a722252ef1e1980fb697fe5cff7506245aec5f07

Modified Files
--------------
src/backend/access/transam/xlog.c | 7 +++++++
src/backend/postmaster/checkpointer.c | 4 ++++
2 files changed, 11 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2025-01-08 21:36:00 pgsql: Disallow NAMEDTUPLESTORE RTEs in stored views, rules, etc.
Previous Message Andrew Dunstan 2025-01-08 16:02:54 pgsql: Set exit status for pgindent if pg_bsd_indent fails