pgsql: Remove unnecessary code to handle CONSTR_NOTNULL

From: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove unnecessary code to handle CONSTR_NOTNULL
Date: 2025-01-07 15:51:14
Message-ID: E1tVBrO-000LTp-1i@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove unnecessary code to handle CONSTR_NOTNULL

Commit 14e87ffa5c54 needlessly added support for CONSTR_NOTNULL entries
to StoreConstraints. It's dead code, so remove it.

To make the situation regarding constraint creation clearer, change
comments in heap_create_with_catalog, StoreConstraints, MergeAttributes
to explain which types of constraint are used on each.

Author: 何建 (Jian He) <jian(dot)universality(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACJufxFxzqrCiUNfjJ0tQU+=nKQkQCGtGzUBude=SMOwj5VNjQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5b291d1c9c09d75982c3270bfa61d4e822087b6a

Modified Files
--------------
src/backend/catalog/heap.c | 13 +++----------
src/backend/commands/tablecmds.c | 15 ++++++++-------
2 files changed, 11 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2025-01-07 18:20:53 pgsql: Fix meson detection of a couple of 64 bit builtins.
Previous Message Peter Geoghegan 2025-01-07 15:39:07 pgsql: Improve nbtree unsatisfiable RowCompare detection.