| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Don't allow GetTransactionSnapshot() in logical decoding |
| Date: | 2024-12-23 10:44:34 |
| Message-ID: | E1tPfvO-000v3V-Fl@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Don't allow GetTransactionSnapshot() in logical decoding
A historic snapshot should only be used for catalog access, not
general queries. We never call GetTransactionSnapshot() during logical
decoding, which is good because it wouldn't be very sensible, so the
code to deal with that was unreachable and untested. Turn it into an
error, to avoid doing that in the future either.
Discussion: https://www.postgresql.org/message-id/a868fe78-ddb4-4b0a-9b96-873d91d93cfd@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/1585ff7387dbcc5657522b2ed87ffd58fd555ee9
Modified Files
--------------
src/backend/utils/time/snapmgr.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-12-23 20:14:41 | pgsql: postgres_fdw: re-issue cancel requests a few times if necessary. |
| Previous Message | David Rowley | 2024-12-23 06:43:28 | pgsql: Fix incorrect source filename references |