From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Declare a couple of variables inside not outside a PG_TRY block. |
Date: | 2024-12-15 20:50:14 |
Message-ID: | E1tMvZ7-002tFw-Rl@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Declare a couple of variables inside not outside a PG_TRY block.
I went through the buildfarm's reports of "warning: variable 'foo'
might be clobbered by 'longjmp' or 'vfork' [-Wclobbered]". As usual,
none of them are live problems according to my understanding of the
effects of setjmp/longjmp, to wit that local variables might revert
to their values as of PG_TRY entry, due to being kept in registers.
But I did happen to notice that XmlTableGetValue's "cstr" variable
doesn't need to be declared outside the PG_TRY block at all (thus
giving further proof that the -Wclobbered warning has little
connection to real problems). We might as well move it inside,
and "cur" too, in hopes of eliminating one of the bogus warnings.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/bf9165bb0c5cea71e1a9cfa0c584c4d176f6c36f
Modified Files
--------------
src/backend/utils/adt/xml.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-12-16 02:24:36 | pgsql: Add some tests for encoding conversion in COPY TO/FROM |
Previous Message | Tom Lane | 2024-12-15 19:14:33 | pgsql: pgbench: fix misprocessing of some nested \if constructs. |