pgsql: Revert "Introduce CompactAttribute array in TupleDesc"

Revert "Introduce CompactAttribute array in TupleDesc"

This reverts commit d28dff3f6cd6a7562fb2c211ac0fb74a33ffd032.

Quite a large number of buildfarm members didn't like this commit and
it's not yet clear why. Reverting this before too many animals turn
red.

Discussion: https://postgr.es/m/CAApHDvr9i6T5=iAwQCxFDgMsthr_obVxgwBaEJkC8KUH6yM3Hw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4171c44c9b791da3c00386dc6d8e6b1842e3036b

Modified Files
--------------
src/backend/access/common/heaptuple.c | 53 +++++++++----------
src/backend/access/common/indextuple.c | 26 ++++-----
src/backend/access/common/tupdesc.c | 70 ++++--------------------
src/backend/access/spgist/spgutils.c | 4 +-
src/backend/catalog/index.c | 2 -
src/backend/commands/tablecmds.c | 4 --
src/backend/executor/execTuples.c | 4 +-
src/backend/utils/cache/relcache.c | 21 +++-----
src/backend/utils/cache/typcache.c | 13 -----
src/include/access/htup_details.h | 4 +-
src/include/access/itup.h | 10 ++--
src/include/access/tupdesc.h | 97 ++--------------------------------
src/include/access/tupmacs.h | 5 +-
src/tools/pgindent/typedefs.list | 1 -
14 files changed, 68 insertions(+), 246 deletions(-)