From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: psql: Sprinkle more CppAsString2() in describe.c |
Date: | 2024-11-28 23:54:54 |
Message-ID: | E1tGoLV-0004dT-QB@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
psql: Sprinkle more CppAsString2() in describe.c
Like 91f5a4a000ea for pg_amcheck, this makes the code more
self-documented as there is less need to look in the headers what a
hardcoded value means. This touches queries related to procedures, AMs,
functions, databases, relations, constraints, collations, types and
extended stats, pulling into psql their *_d.h headers. The queries are
written the same way as originally.
There are still a couple of hardcoded values. These cannot be included
yet as they are not exposed in headers that are safe to use in frontend
code.
Note that describe.c was including pg_am.h that should be used only in
backend code. This is updated to use pg_am_d.h.
Reviewed-by: Daniel Gustafsson, Corey Huinker
Discussion: https://postgr.es/m/Zxb2hpca-pZc6zKe@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/18954ce7f69b0a4725b1cf1845ed5fd3874e2a92
Modified Files
--------------
src/bin/psql/describe.c | 155 ++++++++++++++++++++++++++++++------------------
1 file changed, 98 insertions(+), 57 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Richard Guo | 2024-11-29 01:36:19 | Re: pgsql: Avoid mislabeling of lateral references when pulling up a subque |
Previous Message | Tom Lane | 2024-11-28 22:33:30 | pgsql: Avoid mislabeling of lateral references when pulling up a subque |