From: | Nathan Bossart <nathan(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix sign-compare warnings in pg_iovec.h. |
Date: | 2024-11-08 22:14:05 |
Message-ID: | E1t9XEz-000srm-63@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix sign-compare warnings in pg_iovec.h.
The code in question (pg_preadv() and pg_pwritev()) has been around
for a while, but commit 15c9ac3629 moved it to a header file. If
third-party code that includes this header file is built with
-Wsign-compare on a system without preadv() or pwritev(), warnings
ensue. This commit fixes said warnings by casting the result of
pg_pread()/pg_pwrite() to size_t, which should be safe because we
will have already checked for a negative value.
Author: Wolfgang Walther
Discussion: https://postgr.es/m/16989737-1aa8-48fd-8dfe-b7ada06509ab%40technowledgy.de
Backpatch-through: 17
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0fa688406595091c4fb6d65f2d409366cc11394e
Modified Files
--------------
src/include/port/pg_iovec.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2024-11-09 00:49:40 | Re: pgsql: Fix our Windows stat() emulation to handle file sizes > 4GB. |
Previous Message | Tom Lane | 2024-11-08 21:39:45 | pgsql: First-draft release notes for 17.1. |