| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Set MyProc->heldLocks in ProcSleep |
| Date: | 2024-11-04 14:21:50 |
| Message-ID: | E1t7xxm-0008wD-Di@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Set MyProc->heldLocks in ProcSleep
Previously, ProcSleep()'s caller was responsible for setting
MyProc->heldLocks, and we had comments to remind about that. But it
seems simpler to make ProcSleep() itself responsible for it.
ProcSleep() already set the other info about the lock its waiting for
(waitLock, waitProcLock and waitLockMode), so it is natural for it to
set heldLocks too.
Reviewed-by: Maxim Orlov
Discussion: https://www.postgresql.org/message-id/7c2090cd-a72a-4e34-afaa-6dd2ef31440e@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/0464f25b6aa156228982efd46303e8c8dd25cccc
Modified Files
--------------
src/backend/storage/lmgr/lock.c | 8 --------
src/backend/storage/lmgr/proc.c | 11 +++++++----
2 files changed, 7 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-11-04 14:25:01 | pgsql: doc: fix typo in mvcc clarification in commit 2fa255ce9b9 |
| Previous Message | Alvaro Herrera | 2024-11-04 14:19:26 | Re: pgsql: Implement pg_wal_replay_wait() stored procedure |