From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: At end of recovery, reset all sinval-managed caches. |
Date: | 2024-10-25 13:51:48 |
Message-ID: | E1t4KjF-002OMZ-2s@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
At end of recovery, reset all sinval-managed caches.
An inplace update's invalidation messages are part of its transaction's
commit record. However, the update survives even if its transaction
aborts or we stop recovery before replaying its transaction commit.
After recovery, a backend that started in recovery could update the row
without incorporating the inplace update. That could result in a table
with an index, yet relhasindex=f. That is a source of index corruption.
This bulk invalidation avoids the functional consequences. A future
change can fix the !RecoveryInProgress() scenario without changing the
WAL format. Back-patch to v17 - v12 (all supported versions). v18 will
instead add invalidations to WAL.
Discussion: https://postgr.es/m/20240618152349.7f.nmisch@google.com
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a4668c99f0f85ba1b4ab120b5b6e168a6a5faef2
Modified Files
--------------
src/backend/access/transam/xlog.c | 25 ++++++++++++++++++++++
src/backend/storage/ipc/sinvaladt.c | 42 +++++++++++++++++++++++++++++++++++++
src/include/storage/sinvaladt.h | 1 +
3 files changed, 68 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Melanie Plageman | 2024-10-25 14:22:10 | pgsql: Move EXPLAIN counter increment to heapam_scan_bitmap_next_block |
Previous Message | Daniel Gustafsson | 2024-10-25 12:14:51 | pgsql: doc: Fix typo in pg_restore_*_stats function documentation |