From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix C23 compiler warning |
Date: | 2024-10-22 06:34:03 |
Message-ID: | E1t38Sx-001rm3-HH@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix C23 compiler warning
The approach of declaring a function pointer with an empty argument
list and hoping that the compiler will not complain about casting it
to another type no longer works with C23, because foo() is now
equivalent to foo(void).
We don't need to do this here. With a few struct forward declarations
we can supply a correct argument list without having to pull in
another header file.
(This is the only new warning with C23. Together with the previous
fix a67a49648d9, this makes the whole code compile cleanly under C23.)
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://www.postgresql.org/message-id/flat/95c6a9bf-d306-43d8-b880-664ef08f2944%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d2b4b4c2259e21ceaf05e393769b69728bfbee99
Modified Files
--------------
src/include/nodes/pathnodes.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2024-10-22 10:25:30 | pgsql: Make all Perl warnings fatal in 043_wal_replay_wait.pl |
Previous Message | Michael Paquier | 2024-10-22 04:07:08 | pgsql: pg_stat_statements: Add tests for nested queries with level trac |