From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix memory leaks from incorrect strsep() uses |
Date: | 2024-10-18 09:34:14 |
Message-ID: | E1t1jN9-001MHF-Bw@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix memory leaks from incorrect strsep() uses
Commit 5d2e1cc117b introduced some strsep() uses, but it did the
memory management wrong in some cases. We need to keep a separate
pointer to the allocate memory so that we can free it later, because
strsep() advances the pointer we pass to it, and it at the end it
will be NULL, so any free() calls won't do anything.
(This fixes two of the four places changed in commit 5d2e1cc117b. The
other two don't have this problem.)
Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/79692bf9-17d3-41e6-b9c9-fc8c3944222a(at)eisentraut(dot)org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/4b652692e97923298d0c7b9c1c303fc648984d92
Modified Files
--------------
src/common/logging.c | 3 ++-
src/test/regress/pg_regress.c | 7 +++++--
2 files changed, 7 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2024-10-18 15:20:50 | pgsql: Adjust documentation for configuring Linux huge pages. |
Previous Message | Peter Eisentraut | 2024-10-18 09:26:06 | pgsql: Fix strsep() use for SCRAM secrets parsing |