From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: psql: Fix \watch when using interval values less than 1ms |
Date: | 2024-10-14 03:28:25 |
Message-ID: | E1t0Bkv-000jWK-Fw@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
psql: Fix \watch when using interval values less than 1ms
Attempting to use an interval of time less than 1ms would cause \watch
to hang. This was confusing, so let's change the logic so as an
interval lower than 1ms behaves the same as 0.
Comments are added to mention that the internals of do_watch() had
better rely on "sleep_ms", the interval value in milliseconds. While on
it, this commit adds a test to check the behavior of interval values
less than 1ms.
\watch hanging for interval values less than 1ms existed before
6f9ee74d45aa, that has changed the code to support an interval value of
0.
Reported-by: Heikki Linnakangas
Author: Andrey M. Borodin, Michael Paquier
Discussion: https://postgr.es/m/88445e0e-3156-4b9d-afae-9a1a7b1631f6@iki.fi
Backpatch-through: 16
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9f34cae1426fe5ab915c95b7e26b1efffbb2ca0f
Modified Files
--------------
src/bin/psql/command.c | 11 ++++++++---
src/bin/psql/t/001_basic.pl | 10 ++++++++--
2 files changed, 16 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2024-10-14 06:45:02 | pgsql: Remove traces of BeOS. |
Previous Message | Jeff Davis | 2024-10-13 20:44:34 | pgsql: Fixup for pg_set_relation_stats(). |