pgsql: pgbench: Improve result outputs related to failed transactions.

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pgbench: Improve result outputs related to failed transactions.
Date: 2024-10-11 04:50:10
Message-ID: E1sz7bP-000Gs3-Dl@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pgbench: Improve result outputs related to failed transactions.

Previously, per-script statistics were never output when all
transactions failed due to serialization or deadlock errors. However,
it is reasonable to report such information if there are ones even
when there are no successful transaction since these failed
transactions are now objects to be reported.

Meanwhile, if the total number of successful, skipped, and failed
transactions is zero, we don't have to report the number of failed
transactions as similar to the number of skipped transactions, which
avoids to print "NaN%" in lines on failed transaction reports.

Also, the number of transactions in per-script results now includes
skipped and failed transactions. It prevents to print "total of NaN%"
when any transactions are not successfully processed. The number of
transactions actually processed per-script and TPS based on it are now
output explicitly in a separate line.

Author: Yugo Nagata
Reviewed-by: Tatsuo Ishii
Discussion: https://postgr.es/m/20240921003544.2436ef8da9c5c8cb963c651b%40sraoss.co.jp

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cae0f3c40554e85cd004732f3f57b9cb936136d2

Modified Files
--------------
src/bin/pgbench/pgbench.c | 81 +++++++++++++++++++++++++++--------------------
1 file changed, 46 insertions(+), 35 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Álvaro Herrera 2024-10-11 07:54:47 pgsql: Use deconstruct_array_builtin instead of deconstruct_array
Previous Message David Rowley 2024-10-11 04:21:37 pgsql: Adjust EXPLAIN's output for disabled nodes