| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove incorrect function import from pgindent |
| Date: | 2024-10-09 07:41:06 |
| Message-ID: | E1syRJi-002oYd-4x@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove incorrect function import from pgindent
Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything. In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.
Backpatch to all supported versions.
Author: Erik Wienhold <ewie(at)ewie(dot)name>
Reviewed-by: Andrew Dunstan <andrew(at)dunslane(dot)net>
Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c4528fdfa903c74cf99837a554bd3c7e115bb366
Modified Files
--------------
src/tools/pgindent/pgindent | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-10-09 07:41:46 | pgsql: Remove incorrect function import from pgindent |
| Previous Message | Tom Lane | 2024-10-08 23:47:00 | pgsql: Allow roles created by new test to log in under SSPI. |