pgsql: bufmgr: Return early in ScheduleBufferTagForWriteback() if fsync

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: bufmgr: Return early in ScheduleBufferTagForWriteback() if fsync
Date: 2024-10-08 16:57:17
Message-ID: E1syDWP-002jSA-Rh@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

bufmgr: Return early in ScheduleBufferTagForWriteback() if fsync=off

As pg_flush_data() doesn't do anything with fsync disabled, there's no point
in tracking the buffer for writeback. Arguably the better fix would be to
change pg_flush_data() to flush data even with fsync off, but that's a
behavioral change, whereas this is just a small optimization.

Reviewed-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Reviewed-by: Noah Misch <noah(at)leadboat(dot)com>
Discussion: https://postgr.es/m/1f6b50a7-38ef-4d87-8246-786d39f46ab9@iki.fi

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/488f826c729bd570c36df369fa8ac90c9a5a1b46

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-10-08 17:52:19 pgsql: Add min and max aggregates for bytea type.
Previous Message Tom Lane 2024-10-08 15:15:22 pgsql: Silence buildfarm warning chatter from bd1276a3c.