pgsql: Move check for binary mode and on_error option to the appropriat

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Move check for binary mode and on_error option to the appropriat
Date: 2024-10-08 09:26:07
Message-ID: E1sy6Tn-002fb4-C9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Move check for binary mode and on_error option to the appropriate location.

Commit 9e2d870119 placed the check for binary mode and on_error
before default values were inserted, which was not ideal.
This commit moves the check to a more appropriate position
after default values are set.

Additionally, the comment incorrectly mentioned two checks before
inserting defaults, when there are actually three. This commit corrects
that comment.

Author: Atsushi Torikoshi
Reviewed-by: Fujii Masao
Discussion: https://postgr.es/m/8830518a-28ac-43a2-8a11-1676d9a3cdf8@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a39297ec026c556b1bf2963dde766db31a2c3d2d

Modified Files
--------------
src/backend/commands/copy.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2024-10-08 11:26:20 pgsql: Doc: add check to detect non-breaking spaces in the docs.
Previous Message Fujii Masao 2024-10-08 09:23:00 pgsql: Add REJECT_LIMIT option to the COPY command.