From: | Amit Kapila <akapila(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Stabilize the test added by commit 022564f60c. |
Date: | 2024-10-08 07:10:57 |
Message-ID: | E1sy4Mz-002esJ-Uc@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Stabilize the test added by commit 022564f60c.
The test was unstable in branches 14 and 15 as we were relying on the
number of changes in the table having a toast column to start streaming.
On branches >= 16, we have a GUC debug_logical_replication_streaming which
can stream each change, so the test was stable in those branches.
Change the test to use PREPARE TRANSACTION as that should make the result
consistent and test the code changed in 022564f60c.
Reported-by: Daniel Gustafsson as per buildfarm
Author: Hou Zhijie, Amit Kapila
Backpatch-through: 14
Discussion: https://postgr.es/m/8C2F86AA-981E-4803-B14D-E264C0255330@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d759c1a0b864366d3592203c782027825ec4c8c8
Modified Files
--------------
contrib/test_decoding/expected/stream.out | 22 ----------------------
contrib/test_decoding/expected/twophase.out | 23 +++++++++++++++++++++++
contrib/test_decoding/sql/stream.sql | 22 ----------------------
contrib/test_decoding/sql/twophase.sql | 22 ++++++++++++++++++++++
4 files changed, 45 insertions(+), 44 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2024-10-08 07:10:58 | pgsql: Stabilize the test added by commit 022564f60c. |
Previous Message | Amit Kapila | 2024-10-08 05:17:50 | Re: pgsql: Fix fetching default toast value during decoding of in-progress |