pgsql: Modernize to_char's Roman-numeral code, fixing overflow problems

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Modernize to_char's Roman-numeral code, fixing overflow problems
Date: 2024-09-26 15:02:34
Message-ID: E1stq0o-00122e-7r@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Modernize to_char's Roman-numeral code, fixing overflow problems.

int_to_roman() only accepts plain "int" input, which is fine since
we're going to produce '###############' for any value above 3999
anyway. However, the numeric and int8 variants of to_char() would
throw an error if the given input exceeded the integer range, while
the float-input variants invoked undefined-per-C-standard behavior.
Fix things so that you uniformly get '###############' for out of
range input.

Also add test cases covering this code, plus the equally-untested
EEEE, V, and PL format codes.

Discussion: https://postgr.es/m/2956175.1725831136@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/147bbc90f75794e5522dcbadaf2bbe1af3ce574a

Modified Files
--------------
doc/src/sgml/func.sgml | 2 +
src/backend/utils/adt/formatting.c | 92 ++++++++++++++++++++++++++---------
src/test/regress/expected/int8.out | 50 +++++++++++++++++++
src/test/regress/expected/numeric.out | 87 +++++++++++++++++++++++++++++++++
src/test/regress/sql/int8.sql | 8 +++
src/test/regress/sql/numeric.sql | 15 ++++++
6 files changed, 231 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2024-09-26 15:41:18 Re: pgsql: Implement pg_wal_replay_wait() stored procedure
Previous Message Tom Lane 2024-09-26 14:37:58 pgsql: Doc: InitPlans aren't parallel-restricted any more.