pgsql: pg_stat_statements: Expand tests for SET statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_stat_statements: Expand tests for SET statements
Date: 2024-09-25 01:06:01
Message-ID: E1stGTg-000leO-EG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_stat_statements: Expand tests for SET statements

There are many grammar flavors that depend on the parse node
VariableSetStmt. This closes the gap in pg_stat_statements by providing
test coverage for what should be a large majority of them, improving more
the work begun in de2aca288569. This will be used to ease the
evaluation of a path towards more normalization of SET queries with
query jumbling.

Note that SET NAMES (grammar from the standard, synonym of SET
client_encoding) is omitted on purpose, this could use UTF8 with a
conditional script where UTF8 is supported, but that does not seem worth
the maintenance cost for the sake of these tests.

The author has submitted most of these in a TAP test (filled in any
holes I could spot), still queries in a SQL file of pg_stat_statements
is able to achieve the same goal while being easier to look at when
testing normalization patterns.

Author: Greg Sabino Mullane, Michael Paquier
Discussion: https://postgr.es/m/CAKAnmmJtJY2jzQN91=2QAD2eAJAA-Per61eyO48-TyxEg-q0Rg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ba90eac7a9953f6f6fa5e0a0cc7441d09778f8b9

Modified Files
--------------
contrib/pg_stat_statements/expected/utility.out | 95 ++++++++++++++++++++++---
contrib/pg_stat_statements/sql/utility.sql | 47 +++++++++++-
2 files changed, 132 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2024-09-25 04:38:12 pgsql: Doc: Add the steps for upgrading the logical replication cluster
Previous Message Noah Misch 2024-09-25 00:18:16 pgsql: Fix use of uninitialized value in previous commit.