| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Back-patch "Refactor code in tablecmds.c to check and process ta |
| Date: | 2024-09-24 22:27:59 |
| Message-ID: | E1stE0k-000kif-JF@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Back-patch "Refactor code in tablecmds.c to check and process tablespace moves"
Back-patch commits 4c9c359d38ff1e2de388eedd860785be6a49201c and
24843297a96d7be16cc3f4b090aacfc6e5e6839e to v13 and v12. Before those
commits, we held the modifiable copy of the relation's pg_class row
throughout a table_relation_copy_data(). That can last long enough to
copy MaxBlockNumber of data. A subsequent fix will hold LockTuple() for
the lifespan of that modifiable copy. By back-patching this first, we
avoid a needless long-duration LOCKTAG_TUPLE.
Discussion: https://postgr.es/m/20231027214946.79.nmisch@google.com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/dc845383cd12dcbb09b468b2eea94bf549528a4b
Modified Files
--------------
src/backend/commands/tablecmds.c | 210 ++++++++++++++++++++++-----------------
src/include/commands/tablecmds.h | 4 +
2 files changed, 123 insertions(+), 91 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-09-24 23:57:20 | Re: pgsql: Allow meson builds to run test_pg_dump test in installcheck mode |
| Previous Message | Noah Misch | 2024-09-24 22:27:58 | pgsql: Warn if LOCKTAG_TUPLE is held at commit, under debug_assertions. |