pgsql: Restore relmapper state early enough in parallel workers.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Restore relmapper state early enough in parallel workers.
Date: 2024-09-20 00:58:59
Message-ID: E1srRz8-0005pE-OB@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Restore relmapper state early enough in parallel workers.

We need to do RestoreRelationMap before loading catalog-derived
state, else the worker may end up with catalog relcache entries
containing stale relfilenode data. Move up RestoreReindexState
too, on the principle that that should also happen before we
do much of any catalog access.

I think ideally these things would happen even before InitPostgres,
but there are various problems standing in the way of that, notably
that the relmapper thinks "active" mappings should be discarded at
transaction end. The implication of this is that InitPostgres and
RestoreLibraryState will see the same catalog state as an independent
backend would see, which is probably fine; at least, it's been like
that all along.

Per report from Justin Pryzby. There is a case to be made that
this should be back-patched. But given the lack of complaints
before 6e086fa2e and the short amount of time remaining before
17.0 wraps, I'll just put it in HEAD for now.

Discussion: https://postgr.es/m/ZuoU_8EbSTE14o1U@pryzbyj2023

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/126ec0bc76d044d3a9eb86538b61242bf7da6db4

Modified Files
--------------
src/backend/access/transam/parallel.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-09-20 00:59:52 pgsql: Add parameter "connstr" to PostgreSQL::Test::Cluster::background
Previous Message Michael Paquier 2024-09-19 23:59:35 pgsql: psql: Add tests for repeated calls of \bind[_named]