pgsql: psql: Fix memory leak with repeated calls of \bind

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: psql: Fix memory leak with repeated calls of \bind
Date: 2024-09-19 07:25:51
Message-ID: E1srBXz-001kfZ-99@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

psql: Fix memory leak with repeated calls of \bind

Calling \bind repeatedly would cause the memory allocated for the list
of bind parameters to be leaked after each call, as the list is reset
when beginning a single call.

This issue is fixed by making the cleanup of the bind parameter list
more aggressive, refactoring it into a single routine called after
processing a query and before running an individual \bind.

HEAD required more surgery and has been fixed by 87eeadaea143. Issue
introduced by 5b66de3433e2.

Reported-by: Anthonin Bonnefoy
Discussion: https://postgr.es/m/2e5b89af-a351-ff0a-000c-037ac28314ab@gmail.com
Backpatch-through: 16

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c2fb2f9e200f43133e4d910d4d9c27cf5e1bb29d

Modified Files
--------------
src/bin/psql/command.c | 2 +-
src/bin/psql/common.c | 29 +++++++++++++++++++++--------
src/bin/psql/common.h | 1 +
3 files changed, 23 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2024-09-19 11:33:50 pgsql: Move pg_wal_replay_wait() to xlogfuncs.c
Previous Message Michael Paquier 2024-09-19 06:39:18 pgsql: psql: Clean up more aggressively state of \bind[_named], \parse