pgsql: Add some sanity checks in executor for query ID reporting

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add some sanity checks in executor for query ID reporting
Date: 2024-09-18 05:46:17
Message-ID: E1sqnW5-001bjd-DA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add some sanity checks in executor for query ID reporting

This commit adds three sanity checks in code paths of the executor where
it is possible to use hooks, checking that a query ID is reported in
pg_stat_activity if compute_query_id is enabled:
- ExecutorRun()
- ExecutorFinish()
- ExecutorEnd()

This causes the test in pg_stat_statements added in 933848d16dc9 to
complain immediately in ExecutorRun(). The idea behind this commit is
to help extensions to detect if they are missing query ID reports when a
query goes through the executor. Perhaps this will prove to be a bad
idea, but let's see where this experience goes in v18 and newer
versions.

Reviewed-by: Sami Imseih
Discussion: https://postgr.es/m/ZuJb5xCKHH0A9tMN@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/24f5205948093a96edf8213294b3d585ac3fe1fb

Modified Files
--------------
src/backend/executor/execMain.c | 10 ++++++++++
1 file changed, 10 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-09-18 07:14:13 pgsql: Update list of acknowledgments in release notes
Previous Message Fujii Masao 2024-09-18 03:52:43 pgsql: postgres_fdw: Extend postgres_fdw_get_connections to return user