pgsql: Repair pg_upgrade for identity sequences with non-default persis

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Repair pg_upgrade for identity sequences with non-default persis
Date: 2024-09-17 19:53:48
Message-ID: E1sqeGi-001Y7q-79@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Repair pg_upgrade for identity sequences with non-default persistence.

Since we introduced unlogged sequences in v15, identity sequences
have defaulted to having the same persistence as their owning table.
However, it is possible to change that with ALTER SEQUENCE, and
pg_dump tries to preserve the logged-ness of sequences when it doesn't
match (as indeed it wouldn't for an unlogged table from before v15).

The fly in the ointment is that ALTER SEQUENCE SET [UN]LOGGED fails
in binary-upgrade mode, because it needs to assign a new relfilenode
which we cannot permit in that mode. Thus, trying to pg_upgrade a
database containing a mismatching identity sequence failed.

To fix, add syntax to ADD/ALTER COLUMN GENERATED AS IDENTITY to allow
the sequence's persistence to be set correctly at creation, and use
that instead of ALTER SEQUENCE SET [UN]LOGGED in pg_dump. (I tried to
make SET [UN]LOGGED work without any pg_dump modifications, but that
seems too fragile to be a desirable answer. This way should be
markedly faster anyhow.)

In passing, document the previously-undocumented SEQUENCE NAME option
that pg_dump also relies on for identity sequences; I see no value
in trying to pretend it doesn't exist.

Per bug #18618 from Anthony Hsu.
Back-patch to v15 where we invented this stuff.

Discussion: https://postgr.es/m/18618-d4eb26d669ed110a@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/918e21d25178c8ae09808c581a782002f702ed9e

Modified Files
--------------
doc/src/sgml/ref/create_table.sgml | 17 +++++---
src/backend/commands/sequence.c | 5 ++-
src/backend/parser/gram.y | 9 +++-
src/backend/parser/parse_utilcmd.c | 80 +++++++++++++++++++++++-----------
src/bin/pg_dump/pg_dump.c | 17 ++++----
src/test/regress/expected/identity.out | 16 +++++++
src/test/regress/sql/identity.sql | 9 ++++
7 files changed, 112 insertions(+), 41 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2024-09-17 19:57:43 Re: pgsql: Introduce framework for parallelizing various pg_upgrade tasks.
Previous Message Alexander Korotkov 2024-09-17 19:51:15 pgsql: Minor cleanup related to pg_wal_replay_wait() procedure