pgsql: Remove separate locale_is_c arguments

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove separate locale_is_c arguments
Date: 2024-09-13 14:30:19
Message-ID: E1sp7JS-000wBm-Sq@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove separate locale_is_c arguments

Since e9931bfb751, ctype_is_c is part of pg_locale_t. Some functions
passed a pg_locale_t and a bool argument separately. This can now be
combined into one argument.

Since some callers call MatchText() with locale 0, it is a bit
confusing whether this is all correct. But it is the case that only
callers that pass a non-zero locale object to MatchText() end up
checking locale->ctype_is_c. To make that flow a bit more
understandable, add the locale argument to MATCH_LOWER() and GETCHAR()
in like_match.c, instead of implicitly taking it from the outer scope.

Reviewed-by: Jeff Davis <pgsql(at)j-davis(dot)com>
Discussion: https://www.postgresql.org/message-id/84d415fc-6780-419e-b16c-61a0ca819e2b@eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/433d8f40e957c042d7d224e4561ca033252baf37

Modified Files
--------------
src/backend/utils/adt/like.c | 30 +++++++++++++++---------------
src/backend/utils/adt/like_match.c | 20 +++++++++-----------
2 files changed, 24 insertions(+), 26 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2024-09-13 15:18:19 pgsql: Fix contrib/pageinspect's test for sequences.
Previous Message Bruce Momjian 2024-09-13 13:44:18 pgsql: doc PG 17 relnotes: add links to commits