| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Remove emode argument from XLogFileRead() and XLogFileReadAnyTLI |
| Date: | 2024-09-09 23:44:58 |
| Message-ID: | E1sno42-000N53-LA@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Remove emode argument from XLogFileRead() and XLogFileReadAnyTLI()
This change makes the code slightly easier to reason about, because
there is actually no need to know if a specific caller of one of these
routines should fail hard on a PANIC, or just let it go through with a
DEBUG2.
The only caller of XLogFileReadAnyTLI() used DEBUG2, and XLogFileRead()
has never used its emode. This can be simplified since 1bb2558046cc
that has introduced XLogFileReadAnyTLI(), splitting both.
Author: Yugo Nagata
Discussion: https://postgr.es/m/20240906201043.a640f3b44e755d4db2b6943e@sraoss.co.jp
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fba49d5293b4455b25485450baf02af42bf543d7
Modified Files
--------------
src/backend/access/transam/xlogrecovery.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-09-10 03:38:06 | pgsql: Introduce an RTE for the grouping step |
| Previous Message | Masahiko Sawada | 2024-09-09 21:56:28 | pgsql: Add WAL usage reporting to ANALYZE VERBOSE output. |