pgsql: Fix order of parameters in a cost_sort call

From: Richard Guo <rguo(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix order of parameters in a cost_sort call
Date: 2024-09-09 03:59:25
Message-ID: E1snVYj-000Evn-BX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix order of parameters in a cost_sort call

In label_sort_with_costsize, the cost_sort function is called with the
parameters 'input_disabled_nodes' and 'input_cost' in the wrong order.
This does not cause any plan diffs in the regression tests, because
label_sort_with_costsize is only used to label the Sort node nicely
for EXPLAIN, and cost numbers are not displayed in regression tests.

Oversight in e22253467. Fixed by passing arguments in the right
order.

Per report from Alexander Lakhin running UBSan.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/a9b7231d-68bc-f117-a07c-96688f3e6aef@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/87b6c3c0b703c3a71bc640f456a24937744ff30b

Modified Files
--------------
src/backend/optimizer/plan/createplan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Langote 2024-09-09 04:47:27 pgsql: SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY ste
Previous Message Michael Paquier 2024-09-09 02:14:45 pgsql: Add callbacks to control flush of fixed-numbered stats