From: | Amit Langote <amitlan(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing |
Date: | 2024-09-06 07:52:50 |
Message-ID: | E1smTlx-000NQ3-PP@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
SQL/JSON: Fix JSON_TABLE() column deparsing
The deparsing code in get_json_expr_options() unnecessarily emitted
the default column-specific ON ERROR / EMPTY behavior when the
top-level ON ERROR behavior in JSON_TABLE was set to ERROR. Fix that
by not overriding the column-specific default, determined based on
the column's JsonExprOp in get_json_table_columns(), with
JSON_BEHAVIOR_ERROR when that is the top-level ON ERROR behavior.
Note that this only removes redundancy; the current deparsing output
is not incorrect, just redundant.
Reviewed-by: Jian He <jian(dot)universality(at)gmail(dot)com>
Discussion: https://postgr.es/m/CACJufxEo4sUjKCYtda0_qt9tazqqKPmF1cqhW9KBOUeJFqQd2g@mail.gmail.com
Backpatch-through: 17
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cd680b39211c5c3c88a143abcac576a22f996d7a
Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 8 ++++----
src/test/regress/expected/sqljson_jsontable.out | 23 +++++++++++++++++++++++
src/test/regress/sql/sqljson_jsontable.sql | 10 ++++++++++
3 files changed, 37 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2024-09-06 07:53:03 | pgsql: SQL/JSON: Fix JSON_TABLE() column deparsing |
Previous Message | Amit Langote | 2024-09-06 04:29:59 | Re: pgsql: SQL/JSON: Avoid initializing unnecessary ON ERROR / ON EMPTY ste |