pgsql: Avoid installcheck failure in TAP tests using injection_points

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid installcheck failure in TAP tests using injection_points
Date: 2024-09-03 23:56:53
Message-ID: E1sldOG-00020G-H5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid installcheck failure in TAP tests using injection_points

These tests depend on the test module injection_points to be installed,
but it may not be available as the contents of src/test/modules/ are not
installed by default.

This commit adds a workaround based on a scan of pg_available_extensions
to check if the extension is available, skipping the test if it is not.
This allows installcheck to work transparently.

There are more tests impacted by this problem on HEAD, but for now this
addresses only the tests that exist on HEAD and v17 as the release is
close by.

Reported-by: Maxim Orlov
Discussion: https://postgr.es/m/CACG=ezZkoT-pFz6a9XnyToiuR-Wg8fGELqHLoyBodr+2h-77qA@mail.gmail.com
Backpatch-through: 17

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bab1fd9277c2b1ef9ef70552d95a6e16c1f3cad4

Modified Files
--------------
src/test/modules/test_misc/t/005_timeouts.pl | 12 ++++++++++++
src/test/recovery/t/041_checkpoint_at_promote.pl | 11 +++++++++++
2 files changed, 23 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-09-04 01:23:04 pgsql: Fix inconsistent LWLock tranche name "CommitTsSLRU"
Previous Message Jeff Davis 2024-09-03 23:31:27 pgsql: Remember last collation to speed up collation cache.