| From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Cache typarray for fast lookups in binary upgrade mode |
| Date: | 2024-09-02 08:46:50 |
| Message-ID: | E1sl2i1-000En2-LR@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Cache typarray for fast lookups in binary upgrade mode
When upgrading a large schema it adds significant overhead to perform
individual catalog lookups per relation in order to retrieve Oid for
preserving Oid calls. This instead adds the typarray to the TypeInfo
cache which then allows for fast lookups using the existing API. A
35% reduction of pg_dump runtime in binary upgrade mode was observed
with this change.
Reviewed-by: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Discussion: https://postgr.es/m/8F1F1E1D-D17B-4B33-B014-EDBCD15F3F0B@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6ebeeae29626e742bbe16db3fa6fccf1186c0dfb
Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 20 ++++++++------------
src/bin/pg_dump/pg_dump.h | 1 +
2 files changed, 9 insertions(+), 12 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-09-02 10:08:52 | pgsql: Translation updates |
| Previous Message | Peter Eisentraut | 2024-09-02 07:09:49 | pgsql: More use of getpwuid_r() directly |