pgsql: Rename pg_sequence_read_tuple() to pg_get_sequence_data()

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Rename pg_sequence_read_tuple() to pg_get_sequence_data()
Date: 2024-08-29 23:50:02
Message-ID: E1sjotu-0022y7-Iw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Rename pg_sequence_read_tuple() to pg_get_sequence_data()

This commit removes log_cnt from the tuple returned by the SQL function.
This field is an internal counter that tracks when a WAL record should
be generated for a sequence, and it is reset each time the sequence is
restored or recovered. It is not necessary to rebuild the sequence DDL
commands for pg_dump and pg_upgrade where this function is used. The
field can still be queried with a scan of the "table" created
under-the-hood for a sequence.

Issue noticed while hacking on a feature that can rely on this new
function rather than pg_sequence_last_value(), aimed at making sequence
computation more easily pluggable.

Bump catalog version.

Reviewed-by: Nathan Bossart
Discussion: https://postgr.es/m/Zsvka3r-y2ZoXAdH@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a83a944e9fdd573802c82d961126ba07bfb65f98

Modified Files
--------------
src/backend/commands/sequence.c | 17 ++++++++---------
src/bin/pg_dump/pg_dump.c | 4 ++--
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 8 ++++----
src/test/regress/expected/sequence.out | 10 +++++-----
src/test/regress/sql/sequence.sql | 4 ++--
6 files changed, 22 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-08-30 01:43:10 pgsql: Define PG_REPLSLOT_DIR for path pg_replslot/ in data folder
Previous Message Tom Lane 2024-08-29 17:24:28 pgsql: Fix mis-deparsing of ORDER BY lists when there is a name conflic