pgsql: Fix comments on wal_level=minimal, CREATE TABLESPACE and CREATE

From: Noah Misch <noah(at)leadboat(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix comments on wal_level=minimal, CREATE TABLESPACE and CREATE
Date: 2024-08-18 19:06:03
Message-ID: E1sflE3-000KO9-Pw@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix comments on wal_level=minimal, CREATE TABLESPACE and CREATE DATABASE.

Commit 97ddda8a82ac470ae581d0eb485b6577707678bc removed the rmtree()
behavior from XLOG_TBLSPC_CREATE, obsoleting that part of the comment.
The comment's point about XLOG_DBASE_CREATE was wrong when commit
fa0f466d5329e10b16f3b38c8eaf5306f7e234e8 introduced the point. (It
would have been accurate if that commit had predated commit
fbcbc5d06f53aea412130deb52e216aa3883fb8d introducing the second
checkpoint of CREATE DATABASE.) Nothing can skip log_smgrcreate() on
the basis of wal_level=minimal, so don't comment on that.

Commit c6b92041d38512a4176ed76ad06f713d2e6c01a8 expanded WAL skipping
from five specific operations to relfilenodes generally, hence the
CreateDatabaseUsingFileCopy() comment change.

Discussion: https://postgr.es/m/20231008022204.cc@rfd.leadboat.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/64740853f07fd1a8314ad68c38298d7e5afe1acc

Modified Files
--------------
src/backend/access/heap/heapam_handler.c | 4 +---
src/backend/commands/dbcommands.c | 7 ++++---
2 files changed, 5 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2024-08-18 20:00:33 pgsql: Fix cpluspluscheck for pg_verifybackup.h.
Previous Message Bruce Momjian 2024-08-17 02:51:20 pgsql: docs: fix incorrect plpgsql error message