pgsql: Improve more comments in astreamer_gzip.c.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve more comments in astreamer_gzip.c.
Date: 2024-08-16 17:45:35
Message-ID: E1sf115-0000mA-F4@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve more comments in astreamer_gzip.c.

Duplicate the comment from astreamer_plain_writer_new instead of just
referring to it. Add a further note to mention that there are dangers
if anything else is written to the same FILE. Also add a comment where
we dup() the filehandle, referring to the existing comment in
astreamer_gzip_writer_finalize(), because the dup() looks wrong on
first glance without that comment to clarify.

Per concerns expressed by Tom Lane on pgsql-security, and using
some wording suggested by him.

Discussion: http://postgr.es/m/CA+TgmoYTFAD0YTh4HC1Nuhn0YEyoQi0_CENFgVzAY_YReiSksQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/76dd015e859845fc5fe60557328e3a6bbf11be31

Modified Files
--------------
src/fe_utils/astreamer_gzip.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2024-08-16 19:05:35 pgsql: pg_verifybackup: Move skip_checksums into verifier_context.
Previous Message Alvaro Herrera 2024-08-16 17:24:02 pgsql: libpq: Trace all messages received from the server