From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Do not hardcode PG_PROTOCOL_LATEST in NegotiateProtocolVersion |
Date: | 2024-08-15 14:45:26 |
Message-ID: | E1sebjC-004IJo-3Y@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Do not hardcode PG_PROTOCOL_LATEST in NegotiateProtocolVersion
We shouldn't ask the client to use a protocol version later than the
one that they requested. To avoid that, if the client requests a
version newer than the latest one we support, set FrontendProtocol
to the latest version we support, not the requested version. Then,
use that value when building the NegotiateProtocolVersion message.
(It seems good on general principle to avoid setting FrontendProtocol
to a version we don't support, anyway.)
None of this really matters right now, because we only support a
single protocol version, but if that ever changes, we'll need this.
Jelte Fennema-Nio, reviewed by me and incorporating some of my
proposed wording
Discussion: https://postgr.es/m/CAGECzQTyXDNtMXdq2L-Wp=OvOCPa07r6+U_MGb==h90MrfT+fQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/516b87502dc1f99adb5126aa70cc796d53648c92
Modified Files
--------------
src/backend/tcop/backend_startup.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-08-15 15:42:04 | pgsql: Clean up indentation and whitespace inconsistencies in ecpg. |
Previous Message | Dean Rasheed | 2024-08-15 09:37:24 | pgsql: Optimise numeric multiplication using base-NBASE^2 arithmetic. |