| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix pg_rewind debug output to print the source timeline history |
| Date: | 2024-08-08 07:28:40 |
| Message-ID: | E1sbxZg-003EyL-4f@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix pg_rewind debug output to print the source timeline history
getTimelineHistory() is called twice, to read the source and the
target timeline history files. However, the loop to print the file
with the --debug option used the wrong variable when dealing with the
source. As a result, the source's history was always printed as empty.
Spotted while debugging bug #18575, but this does not fix that bug,
just the debugging output. Backpatch to all supported versions.
Discussion: https://www.postgresql.org/message-id/092dd515-b7b4-4fd0-8407-ceca2f02f6ec@iki.fi
Branch
------
REL_17_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a7bf3e66852743503eb32cb38d93c0740dcca00a
Modified Files
--------------
src/bin/pg_rewind/pg_rewind.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2024-08-08 08:50:12 | pgsql: Add a caveat to hash_seq_init_with_hash_value() header comment |
| Previous Message | Peter Eisentraut | 2024-08-08 06:07:55 | pgsql: Revert ECPG's use of pnstrdup() |