pgsql: Improve file header comments for astramer code.

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve file header comments for astramer code.
Date: 2024-08-07 12:56:16
Message-ID: E1sbgDA-0037vy-JO@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve file header comments for astramer code.

Make it clear that "astreamer" stands for "archive streamer".
Generalize comments that still believe this code can only be used
by pg_basebackup. Add some comments explaining the asymmetry
between the gzip, lz4, and zstd astreamers, in the hopes of making
life easier for anyone who hacks on this code in the future.

Robert Haas, reviewed by Amul Sul.

Discussion: http://postgr.es/m/CAAJ_b97O2kkKVTWxt8MxDN1o-cDfbgokqtiN2yqFf48=gXpcxQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/22b4a1b561f830f2af80c21450a4c05f6efbb698

Modified Files
--------------
src/fe_utils/astreamer_file.c | 4 ++++
src/fe_utils/astreamer_gzip.c | 15 +++++++++++++++
src/fe_utils/astreamer_lz4.c | 4 ++++
src/fe_utils/astreamer_zstd.c | 4 ++++
src/include/fe_utils/astreamer.h | 21 +++++++++++++++------
5 files changed, 42 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2024-08-07 15:31:23 pgsql: Refactor/reword some error messages to avoid duplicates
Previous Message Robert Haas 2024-08-07 12:24:33 Re: pgsql: Introduce hash_search_with_hash_value() function