| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Revert "Fix comments in instr_time.h and remove an unneeded cast |
| Date: | 2024-08-06 19:18:54 |
| Message-ID: | E1sbPhu-0030bl-LJ@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Revert "Fix comments in instr_time.h and remove an unneeded cast to int64"
This reverts commit 3dcb09de7b. Tom Lane pointed out that it broke the
abstraction provided by the macros. The callers should not need to
know what the internal type is.
This commit is an exact revert, the next commit will fix the comments
on the macros that incorrectly claim that they return uint64.
Discussion: https://www.postgresql.org/message-id/ZrHkv3MAQfwNSmTG@ip-10-97-1-34.eu-west-3.compute.internal
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/39a138fbef87803ab7fe494243c1ba36a093a0e8
Modified Files
--------------
src/include/portability/instr_time.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-08-06 19:25:26 | pgsql: selfuncs.c: use pg_strxfrm() instead of strxfrm(). |
| Previous Message | Tom Lane | 2024-08-06 16:37:19 | pgsql: Allow parallel workers to cope with a newly-created session user |