pgsql: Parse sequence type and integer metadata in dumpSequence().

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Parse sequence type and integer metadata in dumpSequence().
Date: 2024-07-31 15:13:57
Message-ID: E1sZB1Z-0023GU-Ul@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Parse sequence type and integer metadata in dumpSequence().

This commit modifies dumpSequence() to parse all the sequence
metadata into the appropriate types instead of carting around
string pointers to the PGresult data. Besides allowing us to free
the PGresult storage earlier in the function, this eliminates the
need to compare min_value and max_value to their respective
defaults as strings.

This is preparatory work for a follow-up commit that will improve
the performance of dumpSequence() in a similar manner to how commit
2329cad1b9 optimized binary_upgrade_set_pg_class_oids().

Reviewed-by: Euler Taveira
Discussion: https://postgr.es/m/20240503025140.GA1227404%40nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/23687e925f94e36d2d3172faa053f4540bfbb8d2

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 104 ++++++++++++++++++++++-----------------
src/tools/pgindent/typedefs.list | 1 +
2 files changed, 61 insertions(+), 44 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2024-07-31 15:13:58 pgsql: Improve performance of dumpSequenceData().
Previous Message David Rowley 2024-07-31 13:29:04 pgsql: Doc: mention executor memory usage for enable_partitionwise* GUC