From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Do not return NULL from pg_newlocale_from_collation(). |
Date: | 2024-07-29 22:18:32 |
Message-ID: | E1sYYhM-001o7Q-8X@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Do not return NULL from pg_newlocale_from_collation().
Previously, pg_newlocale_from_collation() returned NULL as a special
case for the DEFAULT_COLLATION_OID if the provider was libc. In that
case the behavior would depend on the last call to setlocale().
Now, consistent with the other providers, it will return a pointer to
default_locale, which is not dependent on setlocale().
Note: for the C and POSIX locales, the locale_t structure within the
pg_locale_t will still be zero, because those locales are implemented
with internal logic and do not use libc at all.
lc_collate_is_c() and lc_ctype_is_c() still depend on setlocale() to
determine the current locale, which will be removed in a subsequent
commit.
Discussion: https://postgr.es/m/cfd9eb85-c52a-4ec9-a90e-a5e4de56e57d@eisentraut.org
Reviewed-by: Peter Eisentraut, Andreas Karlsson
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8240401437c8e261b4ae95fcc4183db98339cc9e
Modified Files
--------------
src/backend/utils/adt/pg_locale.c | 191 ++++++++++++++++++++++----------------
1 file changed, 110 insertions(+), 81 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2024-07-30 02:00:36 | pgsql: SQL/JSON: Some fixes to JsonBehavior expression casting |
Previous Message | Melanie Plageman | 2024-07-29 19:46:53 | pgsql: Use DELETE instead of UPDATE to speed up vacuum test |