pgsql: Add missing pointer dereference in pg_backend_memory_contexts vi

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Add missing pointer dereference in pg_backend_memory_contexts vi
Date: 2024-07-28 21:53:38
Message-ID: E1sYBpi-001ekM-SP@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Add missing pointer dereference in pg_backend_memory_contexts view

32d3ed816 moved the logic for setting the context's name and ident into
a reusable function. I missed adding a pointer dereference after
copying and pasting the code into that function. The ident parameter is
a pointer to the ident variable in the calling function, so the
dereference is required to correctly determine if the contents of that
variable is NULL or not.

In passing, adjust the if condition to include an == NULL to make it
more clear that it's not checking for == '\0'.

Reported-by: Tom Lane, Coverity
Discussion: https://postgr.es/m/2256588.1722184287@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/da87dc07f16e7435edc601661a6ec71b38bccd25

Modified Files
--------------
src/backend/utils/adt/mcxtfuncs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2024-07-29 00:10:01 pgsql: Refactor pg_set_regex_collation() for clarity.
Previous Message Jeff Davis 2024-07-28 20:35:34 pgsql: Fix whitespace in commit 005c6b833f.