pgsql: Clarify error message and documentation related to typed tables.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Clarify error message and documentation related to typed tables.
Date: 2024-07-26 16:39:53
Message-ID: E1sXNyz-001Khv-7V@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clarify error message and documentation related to typed tables.

We restrict typed tables (those declared as "OF composite_type")
to be based on stand-alone composite types, not composite types
that are the implicitly-created rowtypes of other tables.
But if you tried to do that, you got the very confusing error
message "type foo is not a composite type". Provide a more specific
message for that case. Also clarify related documentation in the
CREATE TABLE man page.

Erik Wienhold and David G. Johnston, per complaint from Hannu Krosing.

Discussion: https://postgr.es/m/CAMT0RQRysCb_Amy5CTENSc5GfsvXL1a4qX3mv_hx31_v74P==g@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5d1d8b3c82c2a796bf7d89f2a5785ce9424acab1

Modified Files
--------------
doc/src/sgml/ref/create_table.sgml | 16 ++++++++--------
src/backend/commands/tablecmds.c | 9 ++++++++-
src/test/regress/expected/typed_table.out | 7 ++++++-
src/test/regress/sql/typed_table.sql | 4 ++++
4 files changed, 26 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-07-26 17:16:18 pgsql: Fix building with MSVC for TLS session disabling
Previous Message Robert Haas 2024-07-26 16:02:19 pgsql: Fix indentation.