pgsql: Improve logical replication connection-failure messages.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve logical replication connection-failure messages.
Date: 2024-07-11 17:21:20
Message-ID: E1sRxTs-001H4x-Ka@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve logical replication connection-failure messages.

These messages mostly said "could not connect to the publisher: %s"
which is lacking context. Add some verbiage to indicate which
subscription or worker process is failing.

Nisha Moond

Discussion: https://postgr.es/m/CABdArM7q1=zqL++cYd0hVMg3u_tc0S=0Of=Um-KvDhLony0cSg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0d8bd0a72ea284ffb1d1154efbe799241cc5edc6

Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 9 ++++++---
src/backend/replication/logical/slotsync.c | 3 ++-
src/backend/replication/logical/tablesync.c | 3 ++-
src/backend/replication/logical/worker.c | 3 ++-
src/backend/replication/slotfuncs.c | 3 ++-
src/backend/replication/walreceiver.c | 9 +++++----
src/test/regress/expected/subscription.out | 2 +-
7 files changed, 20 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-07-12 00:37:12 pgsql: Improve comment of pgstat_read_statsfile()
Previous Message Tom Lane 2024-07-11 15:51:01 pgsql: Add min and max aggregates for composite types (records).