pgsql: Make our back branches compatible with libxml2 2.13.x.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make our back branches compatible with libxml2 2.13.x.
Date: 2024-07-11 00:16:11
Message-ID: E1sRhTn-001BD2-TT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make our back branches compatible with libxml2 2.13.x.

This back-patches HEAD commits 066e8ac6e, 6082b3d5d, e7192486d,
and 896cd266f into supported branches. Changes:

* Use xmlAddChildList not xmlAddChild in XMLSERIALIZE
(affects v16 and up only). This was a flat-out coding mistake
that we got away with due to lax checking in previous versions
of xmlAddChild.

* Use xmlParseInNodeContext not xmlParseBalancedChunkMemory.
This is to dodge a bug in xmlParseBalancedChunkMemory in libxm2
releases 2.13.0-2.13.2. While that bug is now fixed upstream and
will probably never be seen in any production-oriented distro, it is
currently a problem on some more-bleeding-edge-friendly platforms.

* Suppress "chunk is not well balanced" errors from libxml2,
unless it is the only error. This eliminates an error-reporting
discrepancy between 2.13 and older releases. This error is
almost always redundant with previous errors, if not flat-out
inappropriate, which is why 2.13 changed the behavior and why
nobody's likely to miss it.

Erik Wienhold and Tom Lane, per report from Frank Streitzig.

Discussion: https://postgr.es/m/trinity-b0161630-d230-4598-9ebc-7a23acdb37cb-1720186432160@3c-app-gmx-bap25
Discussion: https://postgr.es/m/trinity-361ba18b-541a-4fe7-bc63-655ae3a7d599-1720259822452@3c-app-gmx-bs01

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f85c91a1867b45742bb28e4578ca2b4a0976383f

Modified Files
--------------
src/backend/utils/adt/xml.c | 90 +++++++++++++++++++++++++++----------
src/test/regress/expected/xml.out | 9 ----
src/test/regress/expected/xml_2.out | 3 --
3 files changed, 66 insertions(+), 36 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-07-11 00:24:20 pgsql: Add PgStat_KindInfo.init_shmem_cb
Previous Message Nathan Bossart 2024-07-10 21:38:06 pgsql: Revamp documentation for predefined roles.