pgsql: Suppress "chunk is not well balanced" errors from libxml2.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Suppress "chunk is not well balanced" errors from libxml2.
Date: 2024-07-09 19:01:21
Message-ID: E1sRG5Z-0011SQ-K3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Suppress "chunk is not well balanced" errors from libxml2.

libxml2 2.13 has an entirely different rule than earlier versions
about when to emit "chunk is not well balanced" errors. This
causes regression test output discrepancies for three test cases
that formerly provoked that error (along with others) and now don't.

Closer inspection shows that at least in 2.13, this error is pretty
useless because it can only be emitted after some other more-relevant
error. So let's get rid of the cross-version discrepancy by just
suppressing it. In case some older libxml2 version is capable of
emitting this error by itself, suppress only when some other error
has already been captured.

Like 066e8ac6e and 6082b3d5d, this will need to be back-patched,
but let's check the results in HEAD first. (The patch for xml_2.out,
in particular, is blind since I can't test it here.)

Erik Wienhold and Tom Lane, per report from Frank Streitzig.

Discussion: https://postgr.es/m/trinity-b0161630-d230-4598-9ebc-7a23acdb37cb-1720186432160@3c-app-gmx-bap25
Discussion: https://postgr.es/m/trinity-361ba18b-541a-4fe7-bc63-655ae3a7d599-1720259822452@3c-app-gmx-bs01

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e7192486dded0ca82824fef95eb88b4231bdd4d2

Modified Files
--------------
src/backend/utils/adt/xml.c | 13 +++++++++++++
src/test/regress/expected/xml.out | 35 ++++++++++++++++++++++++++---------
src/test/regress/expected/xml_1.out | 12 ++++++++++++
src/test/regress/expected/xml_2.out | 29 ++++++++++++++++++++++++++---
src/test/regress/sql/xml.sql | 4 ++++
5 files changed, 81 insertions(+), 12 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Jeff Davis 2024-07-09 19:38:28 pgsql: Fix missing invalidations for search_path cache.
Previous Message Thomas Munro 2024-07-09 18:10:09 Re: pgsql: Replace BackendIds with 0-based ProcNumbers