pgsql: Fix limit block handling in pg_wal_summary_contents().

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix limit block handling in pg_wal_summary_contents().
Date: 2024-07-09 00:30:02
Message-ID: E1sQyk6-000v6a-3R@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix limit block handling in pg_wal_summary_contents().

Previously, pg_wal_summary_contents() had two issues,
causing discrepancies between pg_wal_summary_contents()
and the pg_walsummary command on the same WAL summary file:

(1) It did not emit the limit block when that's the only data for
a particular relation fork.
(2) It emitted the same limit block multiple times if the list of
block numbers was long enough.

This commit fixes these issues.

Backpatch to v17 where pg_wal_summary_contents() was added.

Author: Fujii Masao
Reviewed-by: Robert Haas
Discussion: https://postgr.es/m/90980ee6-2da6-42f6-a7b0-b7bae62ae279@oss.nttdata.com

Branch
------
REL_17_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/ab4129091ccc15c3e899878e8bd6733577f83bba

Modified Files
--------------
src/backend/backup/walsummaryfuncs.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2024-07-09 00:30:29 pgsql: Fix limit block handling in pg_wal_summary_contents().
Previous Message David Rowley 2024-07-09 00:16:16 pgsql: Show Parallel Bitmap Heap Scan worker stats in EXPLAIN ANALYZE