pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Symlink pg_replslot robustly on Windows in pg_basebackup test
Date: 2024-07-08 21:36:01
Message-ID: E1sQw1h-000u5L-Sn@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Symlink pg_replslot robustly on Windows in pg_basebackup test

This reverts commit e9f15bc9. Instead of a hacky solution that didn't
work on Windows, we avoid trying to move the directory possibly across
drives, and instead remove it and recreate it in the new location.

Discussion: https://postgr.es/m/20240707070243.sb77kp4ubowauctz@awork3.anarazel.de

Backpatch to release 14 like the previous patch.

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/468b2367d2fe29fe1a53bcba408b472dc8f5051b

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2024-07-08 21:55:36 pgsql: Teach planner how to estimate rows for timestamp generate_series
Previous Message Nathan Bossart 2024-07-08 21:19:49 pgsql: Use CREATE DATABASE ... STRATEGY = FILE_COPY in pg_upgrade.