pgsql: Fix newly introduced issue in EXPLAIN for Materialize nodes

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix newly introduced issue in EXPLAIN for Materialize nodes
Date: 2024-07-05 04:56:40
Message-ID: E1sPazv-000NB1-FT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix newly introduced issue in EXPLAIN for Materialize nodes

The code added in 1eff8279d was lacking a check to see if the tuplestore
had been created. In nodeMaterial.c this is done by ExecMaterial() rather
than by ExecInitMaterial(), so the tuplestore won't be created unless
the node has been executed at least once, as demonstrated by Alexander
in his report.

Here we skip showing any of the new EXPLAIN ANALYZE information when the
Materialize node has not been executed.

Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/fe7fc8fb-86e5-ecb0-3cb2-dd2c9a6c482f@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/53abb1e0ebc38818f31f2ddb15a06feba8e19e6c

Modified Files
--------------
src/backend/commands/explain.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2024-07-05 05:51:55 pgsql: Improve memory management and performance of tuplestore.c
Previous Message Thomas Munro 2024-07-05 03:26:58 pgsql: Add simple codepoint redirections to unaccent.rules.