pgsql: Remove incorrect Asserts in buffile.c

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove incorrect Asserts in buffile.c
Date: 2024-07-03 21:45:08
Message-ID: E1sP7mk-000Cnk-T1@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove incorrect Asserts in buffile.c

Both BufFileSize() and BufFileAppend() contained Asserts to ensure the
given BufFile(s) had a valid fileset. A valid fileset isn't required in
either of these functions, so remove the Asserts and adjust the
comments accordingly.

This was noticed while work was being done on a new patch to call
BufFileSize() on a BufFile without a valid fileset. It seems there's
currently no code in the tree which could trigger these Asserts, so no
need to backpatch this, for now.

Reviewed-by: Peter Geoghegan, Matthias van de Meent, Tom Lane
Discussion: https://postgr.es/m/CAApHDvofgZT0VzydhyGH5MMb-XZzNDqqAbzf1eBZV5HDm3%2BosQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4331a11c62eca7426ad4472be051fe512a04fc80

Modified Files
--------------
src/backend/storage/file/buffile.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2024-07-03 23:21:13 pgsql: Fix typo in GetRunningTransactionData()
Previous Message Nathan Bossart 2024-07-03 19:23:22 pgsql: Improve performance of binary_upgrade_set_pg_class_oids().