From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix overflow in parsing of positional parameter |
Date: | 2024-07-02 07:38:10 |
Message-ID: | E1sOY5Y-0000Q1-RF@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix overflow in parsing of positional parameter
Replace atol with pg_strtoint32_safe in the backend parser and with
strtoint in ECPG to reject overflows when parsing the number of a
positional parameter. With atol from glibc, parameters $2147483648 and
$4294967297 turn into $-2147483648 and $1, respectively.
Author: Erik Wienhold <ewie(at)ewie(dot)name>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Reviewed-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/5d216d1c-91f6-4cbe-95e2-b4cbd930520c(at)ewie(dot)name
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d35cd061998434747c0d1c0f6f2aa1f736f0edb4
Modified Files
--------------
src/backend/parser/scan.l | 8 +++++++-
src/interfaces/ecpg/preproc/pgc.l | 8 +++++++-
src/test/regress/expected/numerology.out | 4 ++++
src/test/regress/sql/numerology.sql | 1 +
4 files changed, 19 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2024-07-02 08:44:44 | pgsql: Remove too demanding test |
Previous Message | Amit Kapila | 2024-07-02 06:21:07 | pgsql: Drop pre-existing subscriptions from the converted subscriber. |