| From: | Nathan Bossart <nathan(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall. |
| Date: | 2024-07-01 15:20:33 |
| Message-ID: | E1sOIpU-003o0N-8U@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add --no-sync to pg_upgrade's uses of pg_dump and pg_dumpall.
There's no reason to ensure that the files pg_upgrade generates
with pg_dump and pg_dumpall have been written safely to disk. If
there is a crash during pg_upgrade, the upgrade must be restarted
from the beginning; dump files left behind by previous pg_upgrade
attempts cannot be reused.
Reviewed-by: Peter Eisentraut, Tom Lane, Michael Paquier, Daniel Gustafsson
Discussion: https://postgr.es/m/20240503171348.GA1731524%40nathanxps13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6e16b1e42003d811562d30b572ac3972238e2957
Modified Files
--------------
src/bin/pg_upgrade/dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-07-01 15:55:25 | pgsql: Preserve CurrentMemoryContext across Start/CommitTransactionComm |
| Previous Message | Peter Eisentraut | 2024-07-01 14:46:32 | pgsql: Remove useless extern keywords |